[SYCL][E2E] Enable bfloat16_example test everywhere #15533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test was recently refactored and got accidentally enabled on HIP, causing post-commit failure. It failed because it had been originally written to only support JIT targets. There seems to be no good reason for this test not to be run on CUDA & HIP backends, so instead of restricting devices it should be run on this patch refactors it to support AOT targets as well.
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
This was referenced Sep 27, 2024
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
approved these changes
Sep 27, 2024
sarnex
approved these changes
Sep 27, 2024
AlexeySachkov
deleted the
private/asachkov/fix-bfloat16-example-in-postcommit
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test was recently refactored and got accidentally enabled on HIP, causing post-commit failure. It failed because it had been originally written to only support JIT targets.
There seems to be no good reason for this test not to be run on CUDA & HIP backends, so instead of restricting devices it should be run on this patch refactors it to support AOT targets as well.